fix: Return swarm http errors as json #1196

paulogr · 2018-01-29T17:50:52Z

Returning errors as json the cli now receives treated messages as bellow:

/Users/paulogr/dev/js-ipfs/src/cli/commands/swarm/connect.js:20
        throw err
        ^

Error: no protocol with name: libp2p-webrtc-star
    at parseError (/Users/paulogr/dev/js-ipfs/node_modules/ipfs-api/src/utils/send-request.js:16:17)
    at ClientRequest.<anonymous> (/Users/paulogr/dev/js-ipfs/node_modules/ipfs-api/src/utils/send-request.js:39:14)
    at Object.onceWrapper (events.js:255:19)
    at ClientRequest.emit (events.js:160:13)

Closes ipfs#1176

dryajov · 2018-01-29T17:58:50Z

src/http/api/resources/swarm.js

@@ -10,13 +10,22 @@ exports = module.exports
 // common pre request handler that parses the args and returns `addr` which is assigned to `request.pre.args`
 exports.parseAddrs = (request, reply) => {
  if (!request.query.arg) {
-    return reply("Argument 'addr' is required").code(400).takeover()
+    const err = 'Argument \'addr\' is required'


can we use '``' instead? Argument 'addr' is required - should work without needing to escape anything.

Done @dryajov

daviddias · 2018-02-15T08:49:07Z

Thanks @paulogr :)

fix: Return swarm http errors as json

150fbad

Closes ipfs#1176

dryajov reviewed Jan 29, 2018

View reviewed changes

fix: Remove scape characteres from error message.

c2dec04

daviddias approved these changes Feb 15, 2018

View reviewed changes

daviddias merged commit 68e7b5a into ipfs:master Feb 15, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Return swarm http errors as json #1196

fix: Return swarm http errors as json #1196

paulogr commented Jan 29, 2018 •

edited

Loading

dryajov Jan 29, 2018

paulogr Jan 29, 2018

paulogr Jan 29, 2018

daviddias commented Feb 15, 2018

fix: Return swarm http errors as json #1196

fix: Return swarm http errors as json #1196

Conversation

paulogr commented Jan 29, 2018 • edited Loading

dryajov Jan 29, 2018

Choose a reason for hiding this comment

paulogr Jan 29, 2018

Choose a reason for hiding this comment

paulogr Jan 29, 2018

Choose a reason for hiding this comment

daviddias commented Feb 15, 2018

paulogr commented Jan 29, 2018 •

edited

Loading