This repository was archived by the owner on Mar 10, 2020. It is now read-only.
use mocha's skip for conditional tests #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
suggested changes
Mar 9, 2018
js/src/files-mfs.js
Outdated
| @@ -37,10 +37,10 @@ module.exports = (common) => { | |||
| after((done) => common.teardown(done)) | |||
|
|
|||
| describe('.mkdir', function () { | |||
| it('make directory on root', (done) => { | |||
| it('make directory on root', function(done) { | |||
There was a problem hiding this comment.
?
The lint pass locally and on travis.
Do you want function (done) with a space instead ?
There was a problem hiding this comment.
@MichaelMure weird, I could bet that standard wouldn't accept that. Yeah I do want the whitespace to make it consistent :)
|
@diasdavid coding style fixed, ready to merge |
daviddias
approved these changes
Mar 9, 2018
|
Thanks @MichaelMure :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully I got all of them.