Skip to content

Finished.I appreciate if I hear any feedback #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Junior-2222
Copy link

No description provided.

@ibrahimcesar ibrahimcesar self-requested a review March 17, 2022 23:43
@ibrahimcesar ibrahimcesar self-assigned this Mar 28, 2022
Copy link
Owner

@ibrahimcesar ibrahimcesar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐⭐⭐⭐ and half / 5

  • Great work
  • Remove the comment on division! Is verbose, is a very well known operation and the link is pointing to the Chinese wikipedia, not of much help in this context
  • You spot the result right, just cut that. 6 cosine is always that number -> 1. Test names should be assertive and that is vague
  • Same for "Other" texts. You could create tests for 'trigonometry' per example.
  • Great that you worked your way to 12 tests!
----------|---------|----------|---------|---------|-------------------
File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
----------|---------|----------|---------|---------|-------------------
All files |     100 |      100 |     100 |     100 |
 math.ts  |     100 |      100 |     100 |     100 |
----------|---------|----------|---------|---------|-------------------

=============================== Coverage summary ===============================
Statements   : 100% ( 18/18 )
Branches     : 100% ( 0/0 )
Functions    : 100% ( 9/9 )
Lines        : 100% ( 18/18 )
================================================================================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants