Skip to content

feat: use resource account #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2024
Merged

feat: use resource account #23

merged 1 commit into from
Apr 22, 2024

Conversation

johanneswuerbach
Copy link
Contributor

Use a resource account instead of injecting the credentials directly into the driver.

This prepares us for using temporary credentials in the future.

@johanneswuerbach johanneswuerbach requested a review from a team as a code owner April 22, 2024 10:07
astromechza
astromechza approved these changes Apr 22, 2024
View reviewed changes
Copy link

@astromechza astromechza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE, is there any way to test this?

@johanneswuerbach
Copy link
Contributor Author

is there any way to test this?

Yes, there is some static validation here, but I've also updated our demo setups to use this and everything looks good.

@johanneswuerbach johanneswuerbach merged commit c213357 into humanitec-architecture:main Apr 22, 2024
1 check passed
@johanneswuerbach johanneswuerbach deleted the resource-account branch April 22, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astromechza astromechza astromechza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanneswuerbach @astromechza