Bugfix/issue 2052 #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both of these had to be made together to pass our tests 1. always pass absolute url to json-schema-ref-parser 2. update json-schema-ref-parser to v11.1.0
|
@tajnymag the upstream package says it also fixed this issue if I'm reading the changelog correctly. I upgraded to the latest version yesterday. Are you able to check if it works on Windows if you revert your changes? https://github.com./APIDevTools/json-schema-ref-parser/releases/tag/v11.2.3 |
|
@mrlubos Went back to the state of the repository before this PR. Tests were failing. Upgraded to the latest schema parser and the tests seem to be succeeding again. Good 👍 |
|
@tajnymag should we revert our fix then? |
|
@mrlubos Sure. I don't really mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of these had to be made together to pass our tests
Should fix: ferdikoomen/openapi-typescript-codegen#2052
(Original PR: ferdikoomen/openapi-typescript-codegen#2053 (comment))