-
Notifications
You must be signed in to change notification settings - Fork 1.2k
closure-compiler-unshaded v20240317 embeds jakarta.annotation-api #4161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for pointing this out. |
Thanks @brad4d, that's definitely good enough for me 🙂 |
@tmortagne Do you know if this has regressed in the latest release? |
Yes, it appears this is a regression in the latest release:
|
Yes, as detailed by @niloc132 and as I should have mentioned a bit more explicitly in the issue description, it's indeed a regression from v20231112. |
This CL also adds a test that ensures we don't accidentally pull in non-compiler code into the maven artifact again. This should address the problem in #4161 PiperOrigin-RevId: 703246074
4bf1cb0 will fix the issue in the next release. |
Are there any plans for a new release to fix this issue? It's been one year since it was reported... Maybe you just need to publish the released artifacts on Maven Central. I see 7 published releases for 2023, only one for 2024 and none for 2025 so far on https://central.sonatype.com/artifact/com.google.javascript/closure-compiler-unshaded . At the same time I see very recent tags at https://github.com./google/closure-compiler/tags . Thanks. |
@lauraharker implemented the creation of the tags for each of our internal-to-Google releases. |
Update: we've pushed a new Maven release - v20250402. |
Thanks, @lauraharker. Unfortunately, we cannot use it yet because of the new dependency on Java 21. |
It can cause some conflicts when you depend on both
closure-compiler-unshaded
andjakarta.annotation-api
directly or through other dependencies.I would have expected it to be a dependency, along with the others declared in the pom file.
The text was updated successfully, but these errors were encountered: