Skip to content

x/build/cmd/golangbuild: update result_adapter to handle Go 1.24's go test -json output #70435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmitshur opened this issue Nov 19, 2024 · 6 comments
Closed

x/build/cmd/golangbuild: update result_adapter to handle Go 1.24's go test -json output #70435

dmitshur opened this issue Nov 19, 2024 · 6 comments
Assignees
@dmitshur
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.24

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Nov 19, 2024 •
edited
Loading

Go 1.24 gained support for emitting build events in structured JSON on stdout, instead of the usual unstructured output on stderr (proposal #62067, release note).

This issue is a continuation of #70402 (comment), tracking the change needed on the LUCI side to be able to take advantage of this new feature.

CC @golang/release, @mknyszek.
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Nov 19, 2024
@dmitshur dmitshur added this to the Go1.24 milestone Nov 19, 2024
@dmitshur dmitshur self-assigned this Nov 19, 2024
@dmitshur dmitshur moved this to In Progress in Go Release Nov 19, 2024
@gabyhelp
Copy link

Related Code Changes

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@dmitshur dmitshur mentioned this issue Nov 19, 2024
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/634237 mentions this issue: main.star: extend gotestjsonbuildtext=1 to NEXT_GO

gopherbot pushed a commit to golang/build that referenced this issue Dec 7, 2024
@dmitshur @mknyszek
main.star: extend gotestjsonbuildtext=1 to NEXT_GO
0c6614a 
We'll drop it from tip and the new release-branch.go1.24 branch as soon
as result_adapter is ready to handle events that contain ImportPath but
not Package fields, but that's not the case this week.

For golang/go#70402.
For golang/go#70435.

Change-Id: Ibd5ce399e2b8e072eb9066a1d304964b41f6cc1b
Reviewed-on: https://go-review.googlesource.com/c/build/+/634237
Reviewed-by: Michael Knyszek <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
@dmitshur
Copy link
Contributor Author

dmitshur commented Jan 15, 2025 •
edited
Loading

crrev.com/c/6174231 updates result_adapter with better support for Go 1.24 structured build events.
Edit: Also crrev.com/c/6179999 to fix handling of a common build failure affecting multiple packages.

After that's in, we can stop setting GODEBUG=gotestjsonbuildtext=1 in configuration.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/642995 mentions this issue: main.star: stop setting GODEBUG=gotestjsonbuildtext=1 in x/build

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/642996 mentions this issue: main.star: stop setting GODEBUG=gotestjsonbuildtext=1 everywhere

gopherbot pushed a commit to golang/build that referenced this issue Jan 15, 2025
@dmitshur @gopherbot
main.star: stop setting GODEBUG=gotestjsonbuildtext=1 in x/build
ed71915 
As part of a gradual rollout, apply the change to one repo first.

For golang/go#70435.

Change-Id: I20e15cd5c72b6119696d701fe5b51b3dd6c5a417
Reviewed-on: https://go-review.googlesource.com/c/build/+/642995
Reviewed-by: Dmitri Shuralyov <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Michael Knyszek <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue Jan 16, 2025
@dmitshur @gopherbot
main.star: stop setting GODEBUG=gotestjsonbuildtext=1 everywhere
ce98cb1 
This is viable to do now that result_adapter is updated with better
support for Go 1.24 structured build events (CL crrev.com/c/6174231).

Fixes golang/go#70435.

Change-Id: I9afbc244438c2f8c1b0c4fddcf0bf3a04ffd6bcd
Reviewed-on: https://go-review.googlesource.com/c/build/+/642996
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Michael Knyszek <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
@gopherbot
Copy link
Contributor

Closed by merging CL 642996 (commit golang/build@ce98cb1) to luci-config.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Release Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitshur dmitshur

Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Go1.24
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @gabyhelp