Optimize GridMap rendering scenario quadruple-getters #105563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimizes GridMap rendering scenario quadruple-getters.
smix8
force-pushed
the
gridmap_get_quadrupled
branch
from
783513f to
172fbe4
Compare
Calinou
approved these changes
Apr 22, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes GridMap rendering scenario quadruple-getters.
While trying to fix #105562 I noticed that GridMap had a really wasteful way of getting the rendering scenario in a few places (or navigation map).
That quadruple getter for the rendering scenario can only be called once per function and outside the loops, instead of x-times. Especially the cell loop could call this a few thousand times for no reason. Also makes the code lines shorter and more readable.