Skip to content

Make the position and the size of FileSystem controls more precise #105560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BrotherShort
Copy link
Contributor

Before: The rename LineEdit is too long.
before1

After:
after1

Before: Text is out of hightlight backgroud.
before2

After:
after2

Before: The rename LineEdit covers the icon.
before3

After:
after3

Before: When right-to-left, The rename LineEdit and tag icons are offset.
before4

After:
after4

@BrotherShort BrotherShort requested review from a team as code owners April 19, 2025 09:04
@KoBeWi KoBeWi added this to the 4.5 milestone Apr 19, 2025
@KoBeWi
Copy link
Member

KoBeWi commented Apr 26, 2025

The rename LineEdit covers the icon.

Still happening:

godot.windows.editor.dev.x86_64_kngFhWX8HU.mp4

The code uses real image size for some reason.

@BrotherShort BrotherShort force-pushed the Make-controls-more-precise branch from 3cba7a5 to a386c85 Compare April 27, 2025 18:42
@BrotherShort
Copy link
Contributor Author

The rename LineEdit covers the icon.

Still happening:

godot.windows.editor.dev.x86_64_kngFhWX8HU.mp4
The code uses real image size for some reason.

Fixed.

@BrotherShort
Copy link
Contributor Author

@KoBeWi
Is there any Godot controls layout doc or diagram? Like this:
image
I drew it when i developed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants