Skip to content

Check user/org repo limit instead of doer #34147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 8, 2025
Merged

Check user/org repo limit instead of doer #34147

merged 10 commits into from
Apr 8, 2025

Conversation

DrMaxNix
Copy link
Contributor

@DrMaxNix DrMaxNix commented Apr 7, 2025 •
edited by wxiaoguang
Loading

This PR tries to finally fix the bug mentioned in #30011 and #15504, where the user repo limit is checked when creating a repo in an organization.

Fix #30011

Please verify that this change makes sense, I don't know a lot about the gitea codebase, so I cannot overlook the security implications that this change will have for other parts of the code.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 7, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 7, 2025
TheFox0x7
TheFox0x7 reviewed Apr 7, 2025
View reviewed changes
Copy link
Contributor

@TheFox0x7 TheFox0x7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks reasonable to me, though I'm also not an expert.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 8, 2025
@wxiaoguang wxiaoguang added the backport/v1.23 This PR should be backported to Gitea 1.23 label Apr 8, 2025
@pull-request-size pull-request-size bot added size/L and removed size/XS labels Apr 8, 2025
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Apr 8, 2025
@wxiaoguang
Copy link
Contributor

I think we need a complete fix like this: 8b48d86

Use CanCreateRepoIn , it should be clearer than before and won't be abused.

@wxiaoguang
Copy link
Contributor

And let's add some tests: c654ade

@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Apr 8, 2025
@wxiaoguang wxiaoguang removed the backport/v1.23 This PR should be backported to Gitea 1.23 label Apr 8, 2025
@lunny lunny changed the title Check user/org repo limit instead of doer (30011) Check user/org repo limit instead of doer Apr 8, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 8, 2025
wxiaoguang
wxiaoguang reviewed Apr 8, 2025
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix merge conflict

@lunny lunny merged commit fd7c364 into go-gitea:main Apr 8, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@TheFox0x7 TheFox0x7 TheFox0x7 left review comments

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

UI preventing org repo creation as well if user org limit is reached
5 participants
@DrMaxNix @wxiaoguang @lunny @TheFox0x7 @GiteaBot