Skip to content

fix: checkout ref to ensure tag is there #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

fix: checkout ref to ensure tag is there #306

merged 1 commit into from
Apr 4, 2025

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Apr 4, 2025

Based on actions/checkout#1467 (comment)

Pull Request

Proposed Changes

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance or breaking

@Copilot Copilot AI review requested due to automatic review settings April 4, 2025 06:30
@jmeridth jmeridth requested a review from a team as a code owner April 4, 2025 06:30
@jmeridth jmeridth merged commit c70b26c into main Apr 4, 2025
9 checks passed
@jmeridth jmeridth deleted the jm_checkout_ref branch April 4, 2025 06:30
@github-actions github-actions bot added the fix label Apr 4, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to fix the checkout reference in the GitHub Actions workflow to ensure the correct tag is checked out.

  • Added a "ref" parameter set to ${ TAG_NAME } in the checkout step
  • Updated the GitHub Actions workflow to properly handle version tags

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@@ -20,6 +20,7 @@ jobs:
uses: actions/[email protected]
with:
fetch-tags: true
ref: ${ TAG_NAME }
Copy link
Preview

Copilot AI Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax for variable substitution in GitHub Actions typically uses the expression syntax '${{ ... }}'. Consider updating 'ref: ${ TAG_NAME }' to 'ref: ${{ TAG_NAME }}' or 'ref: ${{ env.TAG_NAME }}' if TAG_NAME is an environment variable.

Suggested change
ref: ${ TAG_NAME }
ref: ${{ TAG_NAME }}

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant