Skip to content

fix: ensure we tag to the github.ref #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

fix: ensure we tag to the github.ref #302

merged 1 commit into from
Apr 4, 2025

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Apr 4, 2025

especially if run manually. otherwise HEAD is tagged (latest on main). nope nope nope

Pull Request

Proposed Changes

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance or breaking

especially if run manually.  otherwise HEAD is tagged (latest on main). nope nope nope

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth self-assigned this Apr 4, 2025
@Copilot Copilot AI review requested due to automatic review settings April 4, 2025 06:01
@jmeridth jmeridth requested a review from a team as a code owner April 4, 2025 06:01
@github-actions github-actions bot added the fix label Apr 4, 2025
@jmeridth jmeridth merged commit f2b14b5 into main Apr 4, 2025
9 checks passed
@jmeridth jmeridth deleted the jm_fix_tagging branch April 4, 2025 06:01
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where the git tag was being applied to HEAD rather than the intended commit by explicitly using a reference. The changes update the tag creation and push commands to include a commit reference.

  • Update tag command to use an explicit reference instead of HEAD.
  • Update push command to align with the tagging change.
Comments suppressed due to low confidence (1)

.github/workflows/major-version-updater.yml:30

  • Ensure that '${{ github.ref }}' reliably points to the intended commit. If the intended behavior is to tag the commit that triggered the workflow, you might consider using '${{ github.sha }}' for clarity and consistency.
git tag v${{ steps.version.outputs.major }} ${{ github.ref }}

Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more

git tag v${{ steps.version.outputs.major }}
git push origin refs/tags/v${{ steps.version.outputs.major }} -f
git tag v${{ steps.version.outputs.major }} ${{ github.ref }}
git push -f origin v${{ steps.version.outputs.major }}
Copy link
Preview

Copilot AI Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with tag creation, consider pushing using the full reference (e.g. 'refs/tags/v${{ steps.version.outputs.major }}') to avoid potential ambiguity in what is being updated on the remote.

Suggested change
git push -f origin v${{ steps.version.outputs.major }}
git push -f origin refs/tags/v${{ steps.version.outputs.major }}

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant