fix: brought back the original script #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] extended to allow manual run Found https://github.com./orgs/community/discussions/116660 which showed the _exact_ error I was getting with actions/publish-action. Signed-off-by: jmeridth <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the GitHub Actions workflow for updating the major tag by restoring the original script behavior and extending functionality to allow manual execution.
- Updated the event trigger from "released" to "published" for better alignment with the triggering event.
- Modified the TAG_NAME environment variable fallback to use github.ref when not provided via input.
- Added steps to check out the repository, extract the version information, and force-update the major tag.
Comments suppressed due to low confidence (1)
.github/workflows/major-version-updater.yml:4
- Changing the event trigger type from 'released' to 'published' could affect the workflow's intended behavior. Please confirm that this change aligns with the intended trigger conditions for releasing tags.
types: [published]
Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more
| workflow_dispatch: | ||
| inputs: | ||
| TAG_NAME: | ||
| description: "Tag name that the major tag will point to (e.g. v1.2.3)" | ||
| required: true | ||
| env: | ||
| TAG_NAME: ${{ github.event.inputs.TAG_NAME || github.event.release.tag_name }} | ||
| TAG_NAME: ${{ github.event.inputs.TAG_NAME || github.ref}} |
There was a problem hiding this comment.
Using github.ref as a fallback for TAG_NAME may lead to unexpected behavior if the reference is not a tag. Consider verifying that the fallback value is always a tag.
Suggested change
| TAG_NAME: ${{ github.event.inputs.TAG_NAME || github.ref}} | |
| TAG_NAME: ${{ github.event.inputs.TAG_NAME || (github.ref.startsWith('refs/tags/') && github.ref) || '' }} |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found https://github.com./orgs/community/discussions/116660 which showed the exact error I was getting with actions/publish-action.
Pull Request
Proposed Changes
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducing@jeffrey-luszczReviewer
fix,documentation,enhancement,infrastructure,maintenanceorbreaking