Skip to content

[active_job] patch retry_job to report all errors during retries #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

solnic
Copy link
Collaborator

@solnic solnic commented Apr 14, 2025

Once Rails 8.0.3 (or 8.1? not sure what's next) is released, we'll have to follow-up and add an ActiveSupport error subscriber instead of patching retry_job.

⚠️ this will increase error reporting rates - we may consider setting active_job_report_after_job_retries to true by default

Closes #2573

@solnic solnic marked this pull request as ready for review April 14, 2025 13:01
@solnic solnic requested review from st0012 and sl0thentr0py April 14, 2025 13:02
@getsentry getsentry deleted a comment from github-actions bot Apr 14, 2025
@solnic
Copy link
Collaborator Author

solnic commented Apr 14, 2025

Danger is still not seeing my changelog entry :(

@getsentry getsentry deleted a comment from github-actions bot Apr 15, 2025
Copy link

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- [active_job] patch retry_job to report all errors during retries ([#2598](https://github.com./getsentry/sentry-ruby/pull/2598))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against dff567f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant