Skip to content

chore(build): Update and hoist rollup-plugin-typescript2 #4524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

lobsterkatie
Copy link
Member

As part of prepping for the new bundling process, this updates rollup-plugin-typescript2 to latest and hoists it into the main package.json.

This update has two effects on the eventual bundles, neither of which affects SDK code.

Updated licensing text:

image

Slightly different tslib implementations:

image

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2022

size-limit report

Path Base Size (c8b3691) Current Size Change
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.69 KB 19.77 KB +0.42% 🔺
@sentry/browser - ES5 CDN Bundle (minified) 62.91 KB 63.18 KB +0.43% 🔺
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.51 KB 18.51 KB +0.01% 🔺
@sentry/browser - ES6 CDN Bundle (minified) 56.8 KB 56.8 KB +0.01% 🔺
@sentry/browser - Webpack (gzipped + minified) 22.21 KB 22.21 KB 0%
@sentry/browser - Webpack (minified) 76.02 KB 76.02 KB 0%
@sentry/react - Webpack (gzipped + minified) 22.24 KB 22.24 KB 0%
@sentry/nextjs Client - Webpack (gzipped + minified) 46.31 KB 46.31 KB 0%
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.22 KB 28.33 KB +0.36% 🔺

@lobsterkatie
Copy link
Member Author

One thing of interest: this makes the ES5 bundles larger, but doesn't change the size of the ES6 bundles. Given what changes it makes perfect sense, it's just a nice illustration of the advantages of using ES6 over ES5.

image

@lobsterkatie lobsterkatie changed the title chore(dev): Update and hoist rollup-plugin-typescript2 chore(build): Update and hoist rollup-plugin-typescript2 Feb 9, 2022
@lobsterkatie lobsterkatie merged commit 5df78df into master Feb 9, 2022
@lobsterkatie lobsterkatie deleted the kmclb-update-rollup-plugin-typescript2 branch February 9, 2022 16:26
@AbhiPrasad AbhiPrasad added this to the Pre 7.0.0 Work milestone Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants