fix(node): Make body capturing more robust #16105
Merged
+69
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
reviewed
Apr 22, 2025
|
|
||
| if (bodyByteLength < MAX_BODY_BYTE_LENGTH) { | ||
| chunks.push(bufferifiedChunk); | ||
| bodyByteLength += bufferifiedChunk.length; |
There was a problem hiding this comment.
should we use length or byteLength here? 🤔
mydea
reviewed
Apr 22, 2025
| } | ||
| } catch { | ||
| // noop |
There was a problem hiding this comment.
Let's add a debug logger message here?
mydea
approved these changes
Apr 23, 2025
|
Ah thanks, forgot to push that change! |
3 tasks
onurtemizkan
pushed a commit
that referenced
this pull request
Apr 24, 2025
I have a hunch that not all frameworks call `req.on('end')` but may only
do `req.on('close')` or whatever else and this is why we are not
reliably capturing bodies.
It should be safe to attach a `req.on('end')` handler, as that doesn't
change any semantics AFAIK.
Fixes #16090
---------
Co-authored-by: Francesco Gringl-Novy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a hunch that not all frameworks call
req.on('end')but may only doreq.on('close')or whatever else and this is why we are not reliably capturing bodies.It should be safe to attach a
req.on('end')handler, as that doesn't change any semantics AFAIK.Fixes #16090