ref(browser): Temporarily add sentry.previous_trace span attribute
#15957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
approved these changes
Apr 2, 2025
Lms24
force-pushed
the
lms/ref-browser-trace-links-attribute
branch
from
723f3cd to
9d54797
Compare
Lms24
force-pushed
the
lms/ref-browser-trace-links-attribute
branch
from
c8faff7 to
643d712
Compare
onurtemizkan
pushed a commit
that referenced
this pull request
Apr 3, 2025
…15957) Temporarily add a span attribute for the previous trace to get trace links working in the EAP-based trace view. This needs to be removed once EAP properly supports span links.
This was referenced Apr 3, 2025
Lms24
added a commit
to getsentry/sentry
that referenced
this pull request
Apr 4, 2025
Bumping the SDK to the latest version because [9.11.0](https://github.com./getsentry/sentry-javascript/releases/tag/9.11.0) includes a [change](getsentry/sentry-javascript#15957) for trace links I want to dog-food.
andrewshie-sentry
pushed a commit
to getsentry/sentry
that referenced
this pull request
Apr 8, 2025
Bumping the SDK to the latest version because [9.11.0](https://github.com./getsentry/sentry-javascript/releases/tag/9.11.0) includes a [change](getsentry/sentry-javascript#15957) for trace links I want to dog-food.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EAP currently doesn't support storing span links. This is on the EAP team's radar but will only be tackled in the future. For now, to unblock our trace linking project, this PR converts the previous trace span link into a span attribute and adds it to the root span (just like the link). We can use this in the product to check for a span link and also query the next trace by this attribute.
Initially, the idea was to convert the link in Relay to a span attribute but this sparked a bunch of convos around how to handle "internal" attributes and if we should keep such temporary things in Relay. Nothing changes about this with the code living in the SDK but it's more a one-off and easier for us to control so after disussing this with @mydea we settled on doing it in the SDK but also comitting to remove it once we can.