-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(logs): initial work on develop docs for sdk logging api #12920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
cc06312
feat(logs): intial work on develop docs for sdk logging api
AbhiPrasad a6a8091
feat: Document otel_log envelope
AbhiPrasad 20cfb44
ref: Clean up logs spec
AbhiPrasad ba6d2dd
fix link to logs pages
AbhiPrasad 7e4a0cb
Apply suggestions from code review
AbhiPrasad e5f87ea
Update develop-docs/sdk/telemetry/logs.mdx
AbhiPrasad cc48024
Update develop-docs/sdk/telemetry/logs.mdx
AbhiPrasad 0540762
fix: close code block
AbhiPrasad 07f741b
fix: Specify that intValue is a string
AbhiPrasad 60c3bdc
fix: Cursor got the change wrong
AbhiPrasad ff4f76e
Merge branch 'master' into abhi-logs-sdk-developer-documentation
AbhiPrasad 3ff6e56
Document log envelope item payload
AbhiPrasad 2d2abe8
enable_sentry_logs -> enable_logs
AbhiPrasad ab38e6e
note about overloading method
AbhiPrasad 5ea9d7d
remove log method
AbhiPrasad 9d7302b
remove emit
AbhiPrasad 6dc07e6
remove obj-c
AbhiPrasad 28cb4b5
add note about crashes
AbhiPrasad 824a186
Document rate limiting and client outcomes
AbhiPrasad 9a130c1
update spec based on attribute changes
AbhiPrasad 75ce009
Merge branch 'master' into abhi-logs-sdk-developer-documentation
AbhiPrasad 021d442
document sentry.origin log attribute
AbhiPrasad c35358a
Make sentry.message.parameter singular matching otel conventions
AbhiPrasad f8a5fda
clarify message parameter attribute and document sdk name/version att…
AbhiPrasad 77d0b95
feat: Document server.address
AbhiPrasad 5fa1be2
Merge branch 'master' into abhi-logs-sdk-developer-documentation
AbhiPrasad 4f667af
clarify sampling controls
AbhiPrasad 4ce5d4d
fix 404 link
AbhiPrasad b3f8c65
Add details about new log envelope item container
AbhiPrasad f5fc96f
move appendix into expandable
AbhiPrasad bc4f23f
Merge branch 'master' into abhi-logs-sdk-developer-documentation
AbhiPrasad 6251603
fix 404 to trace origin
AbhiPrasad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have both? Our SDKs emit an envelope with the
logs
item type. How does theotel_logs
envelope item differs here? As in, if we want to support OTLP logs, why not ingesting them as is instead of maintaining two Sentry specific formats?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We initially started with
otel_log
as the baseline interface. We wanted to use that as the foundation because it meant at minimum we were OTEL compatible, but it also pointed us to a variety of things to think about.We are documenting the
otel_log
format for completeness, given we might need to use this in the future.For the foreseeable future, all SDKs will send events with the
log
payload and envelope item. You can see what this looks like here: getsentry/relay#4592I've added documentation for the
log
payload, and clarified this: 3ff6e56