Skip to content

[flutter_lints] Bump lints dependency to 6.0.0 and bump package to 6.0.0 #9108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

BenjaminPrice
Copy link

@BenjaminPrice BenjaminPrice commented Apr 18, 2025

Bump the dependency on lints from ^5.0.0 to ^6.0.0 in the flutter_lints package. Subsequently also bumping the version of flutter_lints to 6.0.0 to match.

fixes #167384

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Removed mention of NEXT as that's no longer relevant.
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -2,13 +2,13 @@ name: flutter_lints
description: Recommended lints for Flutter apps, packages, and plugins to encourage good coding practices.
repository: https://github.com./flutter/packages/tree/main/packages/flutter_lints
issue_tracker: https://github.com./flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+flutter_lints%22
version: 5.0.0
version: 6.0.0

environment:
sdk: ^3.5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the CI failures, this is no longer correct; lints 6.0 requires 3.8, so this needs to require 3.8 as well.

That also means this PR can't land until after the next stable release, as our policy is to support stable.

Copy link
Author

@BenjaminPrice BenjaminPrice Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. I've updated the environment to require ^3.8.0. This can wait until Flutter ^3.30.0 drops before merging.

@stuartmorgan-g stuartmorgan-g added the waiting for stable update Can't be landed until functionality reaches the stable channel label Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: flutter_lints waiting for stable update Can't be landed until functionality reaches the stable channel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[flutter_lints] Bump dependency lints from ^5.0.0 to ^6.0.0
3 participants