-
Notifications
You must be signed in to change notification settings - Fork 1.7k
lib: dependency updates #10195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: dependency updates #10195
Conversation
Signed-off-by: Eduardo Silva <[email protected]>
9221fd7
to
25f3e56
Compare
Signed-off-by: Eduardo Silva <[email protected]>
@@ -1,12 +1,12 @@ | |||
cmake_minimum_required(VERSION 3.12) | |||
cmake_minimum_required(VERSION 3.20) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change requires changes in run_code_analysis.sh script, because lpenz/ghaction-cmake:0.19 docker image (https://hub.docker.com/r/lpenz/ghaction-cmake) used in that script contains older version of CMake:
$ TEST_PRESET=valgrind SKIP_TESTS='flb-rt-out_td flb-it-network' ./run_code_analysis.sh
...
-- Enabling FLB_REGEX since FLB_PARSER requires
CMake Error at lib/cfl/CMakeLists.txt:1 (cmake_minimum_required):
CMake 3.20 or higher is required. You are running version 3.18.4
-- Configuring incomplete, errors occurred!
See also "/tmp/source/CMakeFiles/CMakeOutput.log".
::error title=popen::> Error 1 while running cmake . -DFLB_BACKTRACE=Off -DFLB_SHARED_LIB=Off -DFLB_DEBUG=On -DFLB_ALL=On -DFLB_EXAMPLES=Off -DFLB_TESTS_INTERNAL=On -DFLB_TESTS_RUNTIME=On -DFLB_WITHOUT_flb-rt-out_td=1 -DFLB_WITHOUT_flb-it-network=1
> > Error 1 while running cmake . -DFLB_BACKTRACE=Off -DFLB_SHARED_LIB=Off -DFLB_DEBUG=On -DFLB_ALL=On -DFLB_EXAMPLES=Off -DFLB_TESTS_INTERNAL=On -DFLB_TESTS_RUNTIME=On -DFLB_WITHOUT_flb-rt-out_td=1 -DFLB_WITHOUT_flb-it-network=1
::endgroup::
+ exit_code=1
+ rm -f /tmp/tmp.u88OHRGpro
+ exit 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer to #10238 for one of the possible solutions
…of CMake in code analysis shell script to match minimal CMake version requirement after upgrade of libs in fluent#10195. Signed-off-by: Marat Abrarov <[email protected]>
…of CMake in code analysis shell script to match minimal CMake version requirement after upgrade of libs in fluent#10195. Signed-off-by: Marat Abrarov <[email protected]>
…of CMake in code analysis shell script to match minimal CMake version requirement after upgrade of libs in fluent#10195. Signed-off-by: Marat Abrarov <[email protected]>
…of CMake in code analysis shell script to match minimal CMake version requirement after upgrade of libs in #10195. Signed-off-by: Marat Abrarov <[email protected]>
FLB_KAFKA
to control globally if Kafka library should be included, this has a higher order of precedence compared toFLB_IN_KAFKA
andFLB_OUT_KAFKA
(default:FLB_KAFKA On
)Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.