This repository was archived by the owner on May 8, 2024. It is now read-only.
serde: substitute versionize with serde
#21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is still draft because I've only done the changes for x86_64. I will do the ARM bindings as well, once I verify that my changes work correctly for x86. |
9 tasks
bchalios
force-pushed
the
from_versionize_to_serde
branch
3 times, most recently
from
65fe517 to
5e352b3
Compare
|
Ok, I added the Aarch64 bindings and also fixed the CI (thanks a lot @roypat for the guidance). |
roypat
reviewed
Nov 10, 2023
bchalios
force-pushed
the
from_versionize_to_serde
branch
from
9d0b0a1 to
a32afec
Compare
roypat
reviewed
Nov 15, 2023
bchalios
force-pushed
the
from_versionize_to_serde
branch
from
a32afec to
0f850cf
Compare
roypat
previously approved these changes
Nov 15, 2023
We have decided to use serde instead of versionize for Firecracker snapshots. This commit replaces all versionize-related derives and manual implementations for the equivalent serde counterparts. Signed-off-by: Babis Chalios <[email protected]>
bindgen auto-generates tests but doesn't put them into #[cfg(test)] modules, and since rustfmt formats assertions across multiple lines, llvm-cov complains that the negative branch of the assertion is not covered. Co-authored-by: Patrick Roy <[email protected]> Signed-off-by: Babis Chalios <[email protected]>
Signed-off-by: Babis Chalios <[email protected]>
bchalios
force-pushed
the
from_versionize_to_serde
branch
from
0f850cf to
0922d76
Compare
Signed-off-by: Babis Chalios <[email protected]>
Signed-off-by: Babis Chalios <[email protected]>
Signed-off-by: Babis Chalios <[email protected]>
Signed-off-by: Babis Chalios <[email protected]>
roypat
reviewed
Jan 9, 2024
roypat
approved these changes
Jan 10, 2024
ShadowCurse
approved these changes
Jan 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We have decided to use serde instead of versionize for Firecracker snapshots.
This PR replaces all versionize-related derives and manual implementations for the equivalent serde counterparts.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.