Move snapshot feature to GA #5165
Merged
+25
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchalios
requested review from
xmarcalx,
kalyazin,
pb8o and
Manciukic
as code owners
bchalios
added
the
Status: Awaiting review
bchalios
force-pushed
the
remove_snapshot_dev_preview
branch
from
36604c7 to
14291c6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5165 +/- ##
==========================================
+ Coverage 83.03% 83.06% +0.03%
==========================================
Files 250 250
Lines 26907 26897 -10
==========================================
Hits 22342 22342
+ Misses 4565 4555 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Closes #1184 |
kalyazin
reviewed
Apr 23, 2025
bchalios
force-pushed
the
remove_snapshot_dev_preview
branch
2 times, most recently
from
6617ae9 to
bf5a215
Compare
bchalios
changed the title
bchalios
force-pushed
the
remove_snapshot_dev_preview
branch
from
bf5a215 to
f6f1c1e
Compare
kalyazin
previously approved these changes
Apr 23, 2025
roypat
reviewed
Apr 23, 2025
bchalios
force-pushed
the
remove_snapshot_dev_preview
branch
from
f6f1c1e to
5f0de97
Compare
roypat
reviewed
Apr 23, 2025
bchalios
force-pushed
the
remove_snapshot_dev_preview
branch
from
5f0de97 to
b15e4de
Compare
Declare full snapshots as fully supported. Diff snapshots remain in development preview status, as we wait to see how these will play with secret hiding. Signed-off-by: Babis Chalios <[email protected]>
bchalios
force-pushed
the
remove_snapshot_dev_preview
branch
from
b15e4de to
ac3b6a2
Compare
roypat
approved these changes
Apr 23, 2025
kalyazin
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Declare full snapshots as fully supported. Diff snapshots remain in development preview status, as we wait to see how these will play with secret hiding.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.