Virtio tweaks #4683
Merged
Virtio tweaks #4683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCurse
force-pushed
the
virtio_tweaks
branch
6 times, most recently
from
9a9b2ad to
af31cb5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4683 +/- ##
==========================================
+ Coverage 82.14% 82.16% +0.01%
==========================================
Files 255 255
Lines 31321 31361 +40
==========================================
+ Hits 25729 25768 +39
- Misses 5592 5593 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ShadowCurse
force-pushed
the
virtio_tweaks
branch
from
af31cb5 to
e98da2d
Compare
ShadowCurse
added
Status: Awaiting review
roypat
previously approved these changes
Jul 16, 2024
9 tasks
ShadowCurse
force-pushed
the
virtio_tweaks
branch
from
e98da2d to
dbcea48
Compare
bchalios
reviewed
Jul 17, 2024
ShadowCurse
force-pushed
the
virtio_tweaks
branch
from
dbcea48 to
7d8af8f
Compare
Add info about queue len and actual size to the message. Signed-off-by: Egor Lazarchuk <[email protected]>
Usize to u64 is safe as Firecracker only supports 64bit platforms where usize == u64. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
virtio_tweaks
branch
from
7d8af8f to
29c0e8c
Compare
bchalios
previously approved these changes
Jul 17, 2024
Replace offset calculations with hard coded values with more descriptive `std::mem::sizeof` with better comments of why the offset should be calculated this way. Additionally replace setting used element fields one by one with single call to `write_obj`. Signed-off-by: Egor Lazarchuk <[email protected]>
Update methods that set values in the `used_ring` to be more descriptive and coherent. Signed-off-by: Egor Lazarchuk <[email protected]>
Rename `signal_used_queue` to `try_signal_queue`. Add a description for the `try_signal_queue` method. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
virtio_tweaks
branch
from
29c0e8c to
fa8f751
Compare
kalyazin
approved these changes
Jul 17, 2024
bchalios
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Minor tweaks to the virtio queue methods:
Reason
These changes were part of #4658, but are quite independent of it, so moved to separate PR.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.