fix: use the right base branch to detect changed files #4441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## firecracker-v1.6 #4441 +/- ##
====================================================
- Coverage 81.55% 81.53% -0.03%
====================================================
Files 240 240
Lines 29367 29367
====================================================
- Hits 23951 23945 -6
- Misses 5416 5422 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Changes: Use either $BUILDKITE_PULL_REQUEST_BASE_BRANCH if available instead of main to get list of changed files. Reason: Comparing changed files with main leads to running unnecessary tests like buid_devctr even when there is no Dockerfile change in the release branch. Signed-off-by: Sudan Landge <[email protected]>
roypat
approved these changes
Mar 15, 2024
wearyzen
added
the
Status: Awaiting review
wearyzen
changed the title
pb8o
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Use either $BUILDKITE_PULL_REQUEST_BASE_BRANCH if available
instead of main to get list of changed files.
Reason:
Comparing changed files with main leads to running unnecessary tests like buid_devctr even when there is no Dockerfile change in the release branch.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.