fix: Remove "filler" variants in aarch64 StaticCpuTemplate enum #4402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Follow up to #4391, but with smaller scope |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4402 +/- ##
=======================================
Coverage 81.53% 81.53%
=======================================
Files 241 241
Lines 29333 29332 -1
=======================================
Hits 23916 23916
+ Misses 5417 5416 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
roypat
force-pushed
the
no-filler-variants
branch
from
59cc84a to
49f1d94
Compare
This enum had filler variants for `Versionize` reasons, which can now be removed due to Versionize no longer being used. Signed-off-by: Patrick Roy <[email protected]>
roypat
force-pushed
the
no-filler-variants
branch
from
49f1d94 to
75e78b8
Compare
roypat
requested review from
ShadowCurse and
zulinx86
and removed request for
ShadowCurse
zulinx86
approved these changes
Jan 24, 2024
ShadowCurse
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enum had filler variants for
Versionizereasons, which can now be removed due to Versionize no longer being used.Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.