Return Firestore-Compat types from QuerySnapshot.docs #4136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bf9b50c The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
schmidt-sebastian
force-pushed
the
mrschmidt/querysnapshotfix
branch
from
00b92d8 to
3bae066
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/querysnapshotfix
branch
from
3bae066 to
7c927b0
Compare
dconeybe
approved these changes
Nov 30, 2020
…base-js-sdk into mrschmidt/querysnapshotfix
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the Firestore Classic SDK leaks the firestore-exp types in QuerySnapshots. We need to use the Firestore Classic's UserDataWriter (similar to what we already do in
DoucmentSnapshot.get()).Fixes #4125, #4134