✨ Add support for SQLAlchemy polymorphic models #1226

PaleNeutron · 2024-11-26T02:48:12Z

Introduce support for SQLAlchemy polymorphic models by adjusting field defaults and handling inheritance correctly in the SQLModel metaclass. Add tests to verify functionality with polymorphic joined and single table inheritance. Refer to #36 .

mmx86 · 2024-12-02T05:55:27Z

@tiangolo
Could you please comment on whether this request has a good chance of being merged?
My team and I, being under time constraints, are currently trying to decide whether to commit to this feature already.

sqlmodel/_compat.py

Co-authored-by: John Pocock <[email protected]>

ndeybach · 2024-12-22T07:53:35Z

We are also exploring using SQLModel in our products. This would be quite an ease of life in how we are building our stack.

@tiangolo do you have a timeline as to when could this be merged / what needs to be done ?

guhur · 2025-01-03T08:46:34Z

Thanks a lot for this PR! We would love to add this feature in our codebase.

Unfortunately, we could not use this PR along with a custom type.

@PaleNeutron would you mind checking this MRE?

(1) the code works fine if you comment DarkHero or if you comment my_model.

(2) however, it fails if both are in the module!

Code

import json
import typing as t

from fastapi.encoders import jsonable_encoder
from pydantic import BaseModel, TypeAdapter

# Warning: we import a deprecated class from the `pydantic` package
# See: https://github.com./pydantic/pydantic/issues/6381
from pydantic._internal._model_construction import ModelMetaclass  # noqa: PLC2701
from sqlalchemy.engine.interfaces import Dialect
from sqlalchemy.orm import mapped_column
from sqlalchemy.sql.type_api import _BindProcessorType, _ResultProcessorType
from sqlmodel import (
    JSON,
    Column,
    Field,
    Session,
    SQLModel,
    TypeDecorator,
    create_engine,
    select,
)


def pydantic_column_type(  # noqa: C901
    pydantic_type: type[t.Any],
) -> type[TypeDecorator]:
    """
    See details here:
    https://github.com./tiangolo/sqlmodel/issues/63#issuecomment-1081555082
    """
    T = t.TypeVar("T")

    class PydanticJSONType(TypeDecorator, t.Generic[T]):
        impl = JSON()
        cache_ok = False

        def __init__(
            self,
            json_encoder: t.Any = json,
        ):
            self.json_encoder = json_encoder
            super().__init__()

        def bind_processor(self, dialect: Dialect) -> _BindProcessorType[T] | None:
            impl_processor = self.impl.bind_processor(dialect)
            if impl_processor:

                def process(value: T | None) -> T | None:
                    if value is not None:
                        if isinstance(pydantic_type, ModelMetaclass):
                            value_to_dump = pydantic_type.model_validate(value)
                        else:
                            value_to_dump = value
                        value = jsonable_encoder(value_to_dump)
                    return impl_processor(value)

            else:

                def process(value: T | None) -> T | None:
                    if isinstance(pydantic_type, ModelMetaclass):
                        value_to_dump = pydantic_type.model_validate(value)
                    else:
                        value_to_dump = value
                    return jsonable_encoder(value_to_dump)

            return process

        def result_processor(
            self,
            dialect: Dialect,
            coltype: object,
        ) -> _ResultProcessorType[T] | None:
            impl_processor = self.impl.result_processor(dialect, coltype)
            if impl_processor:

                def process(value: T) -> T | None:
                    value = impl_processor(value)
                    if value is None:
                        return None

                    if isinstance(value, str):
                        value = json.loads(value)

                    return TypeAdapter(pydantic_type).validate_python(value)

            else:

                def process(value: T) -> T | None:
                    if value is None:
                        return None

                    if isinstance(value, str):
                        value = json.loads(value)

                    return TypeAdapter(pydantic_type).validate_python(value)

            return process

        def compare_values(self, x: t.Any, y: t.Any) -> bool:
            return x == y

    return PydanticJSONType


class MyModel(BaseModel):
    name: str | None = None


class ComplexModel(SQLModel, table=True):
    id: t.Annotated[
        int | None,
        Field(
            default=None,
            primary_key=True,
        ),
    ] = None
    my_model: t.Annotated[
        MyModel | None,
        Field(
            sa_column=Column(pydantic_column_type(MyModel)),
        ),
    ] = None


class Hero(SQLModel, table=True):
    __tablename__ = "hero"
    id: int | None = Field(default=None, primary_key=True)
    hero_type: str = Field(default="hero")

    __mapper_args__ = {
        "polymorphic_on": "hero_type",
        "polymorphic_identity": "hero",
    }


class DarkHero(Hero):
    dark_power: str = Field(
        default="dark",
        sa_column=mapped_column(
            nullable=False, use_existing_column=True, default="dark"
        ),
    )

    __mapper_args__ = {
        "polymorphic_identity": "dark",
    }


engine = create_engine("sqlite:///:memory:", echo=True)
SQLModel.metadata.create_all(engine)
with Session(engine) as db:
    hero = Hero()
    db.add(hero)
    dark_hero = DarkHero(dark_power="pokey")
    db.add(dark_hero)
    db.commit()
    statement = select(DarkHero)
    result = db.exec(statement).all()
assert len(result) == 1
assert isinstance(result[0].dark_power, str)

Corresponding error code

python test.py
Traceback (most recent call last):
  File "/Users/guhur/src/argile-lib-python/test.py", line 101, in <module>
    class DarkHero(Hero):
  File "/Users/guhur/Library/Caches/pypoetry/virtualenvs/argile-lib-python-RxGRaJe1-py3.11/lib/python3.11/site-packages/sqlmodel/main.py", line 542, in __new__
    new_cls = super().__new__(cls, name, bases, dict_used, **config_kwargs)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/guhur/Library/Caches/pypoetry/virtualenvs/argile-lib-python-RxGRaJe1-py3.11/lib/python3.11/site-packages/pydantic/_internal/_model_construction.py", line 202, in __new__
    complete_model_class(
  File "/Users/guhur/Library/Caches/pypoetry/virtualenvs/argile-lib-python-RxGRaJe1-py3.11/lib/python3.11/site-packages/pydantic/_internal/_model_construction.py", line 572, in complete_model_class
    generate_pydantic_signature(init=cls.__init__, fields=cls.model_fields, config_wrapper=config_wrapper),
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/guhur/Library/Caches/pypoetry/virtualenvs/argile-lib-python-RxGRaJe1-py3.11/lib/python3.11/site-packages/pydantic/_internal/_signature.py", line 159, in generate_pydantic_signature
    merged_params = _generate_signature_parameters(init, fields, config_wrapper)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/guhur/Library/Caches/pypoetry/virtualenvs/argile-lib-python-RxGRaJe1-py3.11/lib/python3.11/site-packages/pydantic/_internal/_signature.py", line 115, in _generate_signature_parameters
    kwargs = {} if field.is_required() else {'default': field.get_default(call_default_factory=False)}
                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/guhur/Library/Caches/pypoetry/virtualenvs/argile-lib-python-RxGRaJe1-py3.11/lib/python3.11/site-packages/pydantic/fields.py", line 546, in get_default
    return _utils.smart_deepcopy(self.default)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/guhur/Library/Caches/pypoetry/virtualenvs/argile-lib-python-RxGRaJe1-py3.11/lib/python3.11/site-packages/pydantic/_internal/_utils.py", line 318, in smart_deepcopy
    return deepcopy(obj)  # slowest way when we actually might need a deepcopy
           ^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 172, in deepcopy
    y = _reconstruct(x, memo, *rv)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 265, in _reconstruct
    y = func(*args)
        ^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 264, in <genexpr>
    args = (deepcopy(arg, memo) for arg in args)
            ^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 172, in deepcopy
    y = _reconstruct(x, memo, *rv)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 271, in _reconstruct
    state = deepcopy(state, memo)
            ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 146, in deepcopy
    y = copier(x, memo)
        ^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 231, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
                             ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 172, in deepcopy
    y = _reconstruct(x, memo, *rv)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 271, in _reconstruct
    state = deepcopy(state, memo)
            ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 146, in deepcopy
    y = copier(x, memo)
        ^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 231, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
                             ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 172, in deepcopy
    y = _reconstruct(x, memo, *rv)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 271, in _reconstruct
    state = deepcopy(state, memo)
            ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 146, in deepcopy
    y = copier(x, memo)
        ^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 231, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
                             ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 172, in deepcopy
    y = _reconstruct(x, memo, *rv)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 265, in _reconstruct
    y = func(*args)
        ^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 264, in <genexpr>
    args = (deepcopy(arg, memo) for arg in args)
            ^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 146, in deepcopy
    y = copier(x, memo)
        ^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 231, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
                             ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 172, in deepcopy
    y = _reconstruct(x, memo, *rv)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 271, in _reconstruct
    state = deepcopy(state, memo)
            ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 146, in deepcopy
    y = copier(x, memo)
        ^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 231, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
                             ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 172, in deepcopy
    y = _reconstruct(x, memo, *rv)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 271, in _reconstruct
    state = deepcopy(state, memo)
            ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 146, in deepcopy
    y = copier(x, memo)
        ^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 231, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
                             ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 146, in deepcopy
    y = copier(x, memo)
        ^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 206, in _deepcopy_list
    append(deepcopy(a, memo))
           ^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 146, in deepcopy
    y = copier(x, memo)
        ^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 211, in _deepcopy_tuple
    y = [deepcopy(a, memo) for a in x]
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 211, in <listcomp>
    y = [deepcopy(a, memo) for a in x]
         ^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 172, in deepcopy
    y = _reconstruct(x, memo, *rv)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 271, in _reconstruct
    state = deepcopy(state, memo)
            ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 146, in deepcopy
    y = copier(x, memo)
        ^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 231, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
                             ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 172, in deepcopy
    y = _reconstruct(x, memo, *rv)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 271, in _reconstruct
    state = deepcopy(state, memo)
            ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 146, in deepcopy
    y = copier(x, memo)
        ^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 231, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
                             ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/copy.py", line 161, in deepcopy
    rv = reductor(4)
         ^^^^^^^^^^^
TypeError: cannot pickle 'module' object

adsharma · 2025-01-17T05:26:08Z

This could help with a different kind of polymorphism. Details here.

Specifically:

@fquery.sqlmodel.model()
@dataclass
class Hero:
  ...

Creates two classes Hero (dataclass) and HereoSQLModel (sqlmodel).

Using polymorphism, we could allow the caller to return Hero (dataclass, cheaper when static typing is good enough) or HeroSQLModel if runtime validation is needed.

PaleNeutron · 2025-02-05T01:37:46Z

@guhur , good test, I found a bug through it.

…aleNeutron/sqlmodel into sqlalchemy_polymorphic_support

PaleNeutron · 2025-02-05T07:42:26Z

@John-P Can you review this PR?

adsharma · 2025-02-05T21:02:08Z

tests/test_polymorphic_model.py

+
+@needs_pydanticv2
+def test_polymorphic_joined_table(clear_sqlmodel) -> None:
+    class Hero(SQLModel, table=True):


Would love to see a syntax that's more focused on what the user wants and hides implementation details.
Example:

from fquery.sqlmodel import sqlmodel @sqlmodel class Hero: hero_type: str = polymorphic(default="hero") @sqlmodel class DarkHero(Hero): dark_power: str = field(default="dark", metadata=...)

You can then perform metaprogramming magic inside the sqlmodel decorator to compute exactly the same class definitions you have in the PR here.

Polymorphic orm has a lot of details, and these details are not concerned at dataclass level. So I think keep the origin sqlalchemy syntax is the best choice for early version. Maybe we can improve it at next PR.

I think the key phrase in your comment is for early version. If sqlalchemy syntax was good enough, sqlmodel wouldn't exist :)

How other ORMs are doing it:

Ruby on rails

zenstack/prisma

I think the key points are:

Decorator approach hides inheritance for those who don't like it. Instead it injects behavior.

fquery.sqlmodel already has one_to_many(). Perhaps it could be enhanced with one_to_many("hero_type")

But like you say - probably best done in two steps.

dolfandringa · 2025-02-13T20:17:52Z

My opinion is but one of a regular user, but I'd love this PR to be merged. I would be totally fine with following the sqlalchemy syntax for now and then coming up with a better syntax later. Being able to support polymorphic table inheritance is quite important for me.
Besides that i see a few other things blocking this PR, which I'd be happy to help with, if possible.

I think this PR is lacking the 'feature' tag.
pipelines are failing on python 3.7. Should that still be supported? Both 3.7 and 3.8 reached EOL already.

PaleNeutron · 2025-02-14T02:15:14Z

@dolfandringa

pipelines are failing on python 3.7. Should that still be supported? Both 3.7 and 3.8 reached EOL already.

You can check detail of why python 3.7 fails:

Run actions/setup-python@v5
Installed versions
  Version 3.7 was not found in the local cache
  Error: The version '3.7' with architecture 'x64' was not found for Ubuntu 24.04.

I think it should be fixed by #1276

I think this PR is lacking the 'feature' tag.

I don't know how to add a feature tag.

ahmdatef · 2025-02-22T19:27:10Z

Can't wait for this PR to get merged
Thank you guys for your efforts!

svlandeg · 2025-02-24T10:26:57Z

Thanks for this contribution @PaleNeutron!

We're currently going through the backlog of PRs and may need some time to catch up. We'll get back to you once someone in the team has been able to review this in detail 🙏

AlePiccin · 2025-03-28T17:09:47Z

Any updates on when this feature is gonna be avaliable?

KunxiSun · 2025-04-03T02:43:56Z

Hi @tiangolo,
Any changce we could get this PR merged soon? We would love to see it go live!

dolfandringa · 2025-04-11T10:34:39Z

Hi @tiangolo, Any changce we could get this PR merged soon? We would love to see it go live!

Also @svlandeg

svlandeg · 2025-04-11T11:47:22Z

Please don't continuously ping maintainers directly. As I said earlier on this PR, we have quite a backlog of PRs and we're managing those as well as we can. Having to respond to these pings actually takes more time and certainly doesn't speed up the overall process of maintaining our open-source repo's.

John Lyu added 8 commits November 26, 2024 10:43

support sqlalchemy polymorphic

6d93a46

improve docs

589237b

fix polymorphic_on check

4071b0f

fix polymorphic_on check

48f2a88

fix lint

e6ad74d

fix pydantic v1 support

277953a

fix type hint for <3.10

4aade03

add needs_pydanticv2 mark to test

a3044bb

PaleNeutron marked this pull request as ready for review November 26, 2024 03:26

PaleNeutron changed the title ~~Support SQLAlchemy polymorphic models~~ Add support for SQLAlchemy polymorphic models Nov 26, 2024

PaleNeutron changed the title ~~Add support for SQLAlchemy polymorphic models~~ [feature] Add support for SQLAlchemy polymorphic models Nov 26, 2024

PaleNeutron mentioned this pull request Nov 27, 2024

How do you define polymorphic models similar to the sqlalchemy ones? #36

Open

8 tasks

John Lyu and others added 4 commits December 3, 2024 17:59

improve code structure

015601c

lint

66c1d93

remove effort of pydantic v1

0efd1bf

Merge branch 'main' into sqlalchemy_polymorphic_support

7173b44

John-P reviewed Dec 11, 2024

View reviewed changes

sqlmodel/_compat.py Outdated Show resolved Hide resolved

Update sqlmodel/_compat.py

84d739e

Co-authored-by: John Pocock <[email protected]>

John Lyu and others added 7 commits February 5, 2025 10:21

fix default value is InstrumentedAttribute in inherit

dbd0101

Merge branch 'sqlalchemy_polymorphic_support' of https://github.com./P…

88670a5

…aleNeutron/sqlmodel into sqlalchemy_polymorphic_support

fix inherit order

b1ed8c3

support python < 3.9

5d1bf5c

🎨 [pre-commit.ci] Auto format from pre-commit.com hooks

ccbb92a

skip polymorphic in pydantic v1

d0d0288

Merge branch 'sqlalchemy_polymorphic_support' of https://github.com./P…

525373d

…aleNeutron/sqlmodel into sqlalchemy_polymorphic_support

Merge branch 'main' into sqlalchemy_polymorphic_support

ab965f0

adsharma reviewed Feb 5, 2025

View reviewed changes

PaleNeutron changed the title ~~[feature] Add support for SQLAlchemy polymorphic models~~ ✨[feature] Add support for SQLAlchemy polymorphic models Feb 14, 2025

dolfandringa mentioned this pull request Feb 19, 2025

👷 Fix py3.7 tests, use ubuntu-22.04 for test jobs #1276

Closed

svlandeg added the feature New feature or request label Feb 20, 2025

Merge branch 'main' into sqlalchemy_polymorphic_support

68963e7

svlandeg changed the title ~~✨[feature] Add support for SQLAlchemy polymorphic models~~ ✨ Add support for SQLAlchemy polymorphic models Feb 20, 2025

Merge branch 'main' into sqlalchemy_polymorphic_support

95c6a1e

disable pydantic warning during polymorphic

c1dff79

hsiung-bf pushed a commit to hsiung-bf/sqlmodel that referenced this pull request Apr 2, 2025

Merge polymorphic models support from upstream PR fastapi#1226

031d2a4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Add support for SQLAlchemy polymorphic models #1226

✨ Add support for SQLAlchemy polymorphic models #1226

PaleNeutron commented Nov 26, 2024 •

edited

Loading

mmx86 commented Dec 2, 2024

ndeybach commented Dec 22, 2024

guhur commented Jan 3, 2025 •

edited

Loading

adsharma commented Jan 17, 2025

PaleNeutron commented Feb 5, 2025

PaleNeutron commented Feb 5, 2025

adsharma Feb 5, 2025

PaleNeutron Feb 6, 2025 •

edited

Loading

adsharma Feb 6, 2025

dolfandringa commented Feb 13, 2025

PaleNeutron commented Feb 14, 2025 •

edited

Loading

ahmdatef commented Feb 22, 2025

svlandeg commented Feb 24, 2025

AlePiccin commented Mar 28, 2025

KunxiSun commented Apr 3, 2025

dolfandringa commented Apr 11, 2025

svlandeg commented Apr 11, 2025

✨ Add support for SQLAlchemy polymorphic models #1226

Are you sure you want to change the base?

✨ Add support for SQLAlchemy polymorphic models #1226

Conversation

PaleNeutron commented Nov 26, 2024 • edited Loading

mmx86 commented Dec 2, 2024

ndeybach commented Dec 22, 2024

guhur commented Jan 3, 2025 • edited Loading

adsharma commented Jan 17, 2025

PaleNeutron commented Feb 5, 2025

PaleNeutron commented Feb 5, 2025

adsharma Feb 5, 2025

Choose a reason for hiding this comment

PaleNeutron Feb 6, 2025 • edited Loading

Choose a reason for hiding this comment

adsharma Feb 6, 2025

Choose a reason for hiding this comment

dolfandringa commented Feb 13, 2025

PaleNeutron commented Feb 14, 2025 • edited Loading

ahmdatef commented Feb 22, 2025

svlandeg commented Feb 24, 2025

AlePiccin commented Mar 28, 2025

KunxiSun commented Apr 3, 2025

dolfandringa commented Apr 11, 2025

svlandeg commented Apr 11, 2025

PaleNeutron commented Nov 26, 2024 •

edited

Loading

guhur commented Jan 3, 2025 •

edited

Loading

PaleNeutron Feb 6, 2025 •

edited

Loading

PaleNeutron commented Feb 14, 2025 •

edited

Loading