Skip to content

♻️ Replace email types from str to EmailStr in config.py #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

jpizquierdo
Copy link
Contributor

Replaced email types from str to EmailStr in config.py because SQLModel supports it since version 0.0.19:

https://sqlmodel.tiangolo.com/release-notes/#0019
fastapi/sqlmodel#966

@jpizquierdo jpizquierdo marked this pull request as draft February 16, 2025 14:19
@jpizquierdo jpizquierdo marked this pull request as ready for review February 16, 2025 14:20
@alejsdev alejsdev changed the title Replaced email types from str to EmailStr in config.py ♻️ Replaced email types from str to EmailStr in config.py Feb 18, 2025
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! 🚀

@tiangolo tiangolo changed the title ♻️ Replaced email types from str to EmailStr in config.py ♻️ Replace email types from str to EmailStr in config.py Feb 18, 2025
@tiangolo tiangolo changed the title ♻️ Replace email types from str to EmailStr in config.py ♻️ Replace email types from str to EmailStr in config.py Feb 18, 2025
@tiangolo tiangolo merged commit 9f6f8f0 into fastapi:master Feb 18, 2025
17 of 18 checks passed
JBLangton pushed a commit to JBLangton/full-stack-fastapi-template that referenced this pull request Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants