Bug/#25 fix transitive dependencies required by generated api client #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaklakariada
requested changes
Apr 30, 2024
kaklakariada
approved these changes
Apr 30, 2024
kaklakariada
deleted the
bug/#25-Fix-transitive-dependencies-required-by-generated-API-client
branch
ahsimb
reviewed
Apr 30, 2024
|
|
||
| In order to create file `pyproject.toml` | ||
| * In file `noxfile.py` you need to replace mode `update` by `generate` | ||
| * Additionally in file `openapi_config.yml` you need to specify a non-existing top-level directory as `name` and a package that does not contain slashes, e.g. |
There was a problem hiding this comment.
"... a non-existing top-level directory as name ..." That refers to the project_name_override: "generate" in the yaml below. Could you make this more explicit?
| The easiest way is to make openapi-python-client create a dedicated file `pyproject.toml` and copy the transitive dependencies from there to SAPIPY's file `pyproject.toml`. | ||
|
|
||
| In order to create file `pyproject.toml` | ||
| * In file `noxfile.py` you need to replace mode `update` by `generate` |
There was a problem hiding this comment.
That must refer to the this call
session.run(
"openapi-python-client",
"update",
"--url", f"{SAAS_HOST}/openapi.json",
"--config", "openapi_config.yml",
silent=silent,
)
in the generate_api function. Should we be specific?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25