Skip to content

Separate long duration tests #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ckunki opened this issue May 22, 2024 · 1 comment · Fixed by #54
Closed

Separate long duration tests #53

ckunki opened this issue May 22, 2024 · 1 comment · Fixed by #54
Assignees
Labels
refactoring Code improvement without behavior change

Comments

@ckunki
Copy link
Collaborator

ckunki commented May 22, 2024

In the scope of issue #45 a test case was implemented and added to SAPIPY.
In consequence the duration of integration tests increased significantly.

To enable faster turn around cycles the current issue requests to

  • Separate such long-running tests should be from faster tests
  • Enable to control execution of these slow tests by a keyword in the commit message

See documentation and discussions on GitHub

@ckunki ckunki added the refactoring Code improvement without behavior change label May 22, 2024
@ckunki ckunki changed the title Enable skipping long duration tests Separate long duration tests May 22, 2024
@ckunki ckunki self-assigned this May 22, 2024
@ckunki
Copy link
Collaborator Author

ckunki commented May 22, 2024

See annotation @pytest.mark.skipif in integration tests of pytest-idte for example:

default_version_only=pytest.mark.skipif(
    "EXASOL_VERSION" in os.environ and os.environ["EXASOL_VERSION"] != default_version,
    reason="""...""",
)

And see example for detecting keywords in commit messages in ai-lab's workflow check_ci.yaml.

    if: "contains(github.event.head_commit.message, '[run-notebook-tests]')"

See also pytest documentation:

[tool.pytest.ini_options]
markers = [
    "slow: marks tests as slow (deselect with '-m \"not slow\"')",
    "serial",
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
1 participant