-
Notifications
You must be signed in to change notification settings - Fork 5.1k
fix: DocLink routing; use internal link component #15327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Maybe the errors will still happen on a few other places as there are multiple components being used for links across the app, but at least for those in the Learn section boxes it should fix it:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree this is a bug that needed to be fixed, since these were not using the appropriate NextLink (which InlineLink
uses under-the-hood) to properly handle /locale/
and internal page routing.
This does not fix #15337 which is an unrelated, and more global problem where direct links to say https://ethereum.org/learn are not being automatically forwarded to the default locale, ie https://ethereum.org/en/learn
Pulling this in (Thanks @microHoffman!) but keeping that issue open
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2025 Ethereum.org Contributor: Join the [ethereum.org Discord server](https://ethereum.org/discord) to explore more ways to contribute to the project. Depending on the tasks you complete, you may also unlock additional rewards. Visit [ethereum.org/contributing](https://ethereum.org/contributing) to learn more.Head to gitpoap.io & connect your GitHub account to mint!Keep buidling, keep learning, and let's grow the Ethereum open-source community together 🌱 Learn more about GitPOAPs here. |
@all-contributors please add @microHoffman for bug fix |
I've put up a pull request to add @microHoffman! 🎉 |
Description
Currently when clicking on internal link in Learn page ( https://ethereum.org/en/learn/ ), it ended up in 404 redirect, because of the missing i18n (links are pointed to
https://ethereum.org/quizzes/
and not tohttps://ethereum.org/[locale]/quizzes/
m which resulted in 404 page not found.I mean links in these sections:

I've fixed it by using the
InlineLink
component inDocLink
component, which handles the addition of i18n locale to links automatically.