Skip to content

Add support for hidden SSID's Multi WiFi #7629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 21, 2021
Merged

Add support for hidden SSID's Multi WiFi #7629

merged 5 commits into from
Jan 21, 2021

Conversation

Erriez
Copy link
Contributor

@Erriez Erriez commented Oct 3, 2020

Add support for hidden SSID's as discussed with @devyte. Algorithm:

  • Power-on
  • Connect to previous saved WiFi
  • Run WiFi scan
  • Connect in a loop to detected WiFi SSID's reported by WiFi scan, sorted at RSSI (signal strength)
  • WiFi scan cannot report hidden SSID's -> Connect in a loop to the remaining registered SSID's

See issue #2246

@Erriez Erriez mentioned this pull request Oct 3, 2020
Closed
devyte
devyte requested changes Oct 14, 2020
View reviewed changes
Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing, then I'm good.

@Erriez
Copy link
Contributor Author

Erriez commented Oct 14, 2020

@devyte Thanks for your review and I agree with your changes. Can this automatically be merged, or is a manual interaction needed from me?

@devyte
Copy link
Collaborator

devyte commented Oct 14, 2020

Just implement in your local branch, then push. PR will be updated automatically. I'll see that, wait for CI, then merge.

@devyte devyte mentioned this pull request Oct 14, 2020
Closed
@Erriez
Copy link
Contributor Author

Erriez commented Oct 14, 2020

Just implement in your local branch, then push. PR will be updated automatically. I'll see that, wait for CI, then merge.

Perfect, I will do that.

@Erriez Erriez force-pushed the feature/issue-2246-multi-wifi-hidden branch from 83c6b3a to 0d94b5f Compare October 15, 2020 17:57
Erriez
Erriez commented Oct 15, 2020
View reviewed changes
Copy link
Contributor Author

@Erriez Erriez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devyte I've added WiFi persistent option as well which looks like common for most examples.

@earlephilhower earlephilhower requested a review from devyte October 28, 2020 05:07
@KimCarlsen
Copy link

@devyte Any chance in review of this? thanks

@devyte devyte added this to the 3.0.0 milestone Jan 21, 2021
@devyte devyte merged commit 2402958 into esp8266:master Jan 21, 2021
@Erriez Erriez deleted the feature/issue-2246-multi-wifi-hidden branch January 23, 2021 10:14
@d-a-v d-a-v mentioned this pull request Mar 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devyte devyte devyte approved these changes

Assignees
No one assigned
Labels
component: libraries hacktoberfest-accepted Hacktoberfest type: enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Erriez @devyte @KimCarlsen @earlephilhower