Skip to content

fix device tests #6861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 3, 2019
Merged

fix device tests #6861

merged 13 commits into from
Dec 3, 2019

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Nov 30, 2019

web server post test is (temporarily) removed due to general pyton2=>3 failure

@earlephilhower
Copy link
Collaborator

Thanks, @d-a-v. Did you intend to remove the ResetMethod from the FQBN?

@d-a-v
Copy link
Collaborator Author

d-a-v commented Dec 1, 2019

@earlephilhower the reset method was wrong since recent changes in boards.txt.
I had changed to rely on default value but it is true that an explicit value is better.
Fixed.

@d-a-v d-a-v merged commit ee24cff into esp8266:master Dec 3, 2019
@d-a-v d-a-v deleted the hosttestsupd branch December 3, 2019 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d-a-v @earlephilhower @devyte