Update EEPROM library documentation #6548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by @d-a-v #6537 (comment)
Update EEPROM description with mention of current implementation limitations
Move ESP_EEPROM to Other Libraries, update description from upstream README
Add https://github.com./xoseperez/eeprom_rotate to Other Libraries as an alternative
Note:
Both libraries depend on #6543
ESP_EEPROM is reimplementing EEPROM class, so the default address would be different from the original library when upgrading to 2.6.0 (for example, using 4m 1m spiffs address is shifted by 1 sector)
Rotate library only uses it for automatic calculation, which user can override. Default ("last") sector is calculated by subtracting 5 sectors from ESP::getFlashChipSize()