Wakeup delayed scheduling #6485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caveat: this PR implies and contains #6307 - both are unconditional requirements for using the core schedule class from CoopTasks. |
dok-net
force-pushed
the
wakeup_delayed_scheduling
branch
from
5aacaa4 to
e57cecc
Compare
dok-net
force-pushed
the
wakeup_delayed_scheduling
branch
3 times, most recently
from
afe402c to
9734760
Compare
dok-net
force-pushed
the
wakeup_delayed_scheduling
branch
2 times, most recently
from
be12074 to
dc1219e
Compare
devyte
requested changes
Sep 28, 2019
dok-net
force-pushed
the
wakeup_delayed_scheduling
branch
3 times, most recently
from
b294bb1 to
2ad8442
Compare
dok-net
force-pushed
the
wakeup_delayed_scheduling
branch
3 times, most recently
from
4cb7a7b to
69af810
Compare
devyte
approved these changes
Oct 7, 2019
dok-net
force-pushed
the
wakeup_delayed_scheduling
branch
3 times, most recently
from
5f959a9 to
dbb1f48
Compare
dok-net
force-pushed
the
wakeup_delayed_scheduling
branch
2 times, most recently
from
2a06c11 to
ee9140d
Compare
dok-net
force-pushed
the
wakeup_delayed_scheduling
branch
from
ee9140d to
861194e
Compare
d-a-v
reviewed
Oct 27, 2019
|
Out of curiosity, why is there a need for a FIFO when functions are called pseudo-asynchronously with potentially different timings ? |
…heduled function out from a delayed execution and makes it run on the next scheduler iteration.
Add check for periodic yield to scheduled functions run-loop.
…ing compared to FastScheduler as well as sequential calls from loop().
…e_function() / run_scheduled_functions().
…value vs. that at registering function with scheduler.
…ming. In the future, async future's .then() might take advantage of this direction.
dok-net
force-pushed
the
wakeup_delayed_scheduling
branch
from
dd3952a to
e12a369
Compare
|
I commented this in the commit 2 months ago:
This affected test results with the use of CoopTasks (in this context, think of these as preemptable scheduled functions, stackful coroutines). |
d-a-v
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use case for the ESP8266 core schedule class that needs the capability to let recurrent, delayed functions run immediately on the next iteration of the scheduler without taking into account a remaining delay or repeat timeout.
This PR [originally added] an optional parameter
const std::atomic<bool>* wakeupTokentoschedule_recurrent_function_us(). This was changed, after review comments, into astd::function<bool(void)>alarm polling callback.The remaining delay or the logic by which the scheduled function return value determines whether to keep scheduling for execution or to be removed from scheduling is unaltered by the alarm.
CoopTask release 2.0.0 depends on this PR for it's new Semaphore with milliseconds timeout.