Skip to content

esptool.py: disable 9600bauds in menu for flash upload serial speed #6292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 13, 2019
Merged

esptool.py: disable 9600bauds in menu for flash upload serial speed #6292

merged 3 commits into from
Jul 13, 2019

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Jul 12, 2019 •
edited
Loading

Users can be mistaken by some board documentation stating to use 9600bauds.
Flash upload speed at 9600bauds doesn't work with esptool.py.
(ref)

(+ minor cosmetics update in host emulation makefile)

earlephilhower
earlephilhower approved these changes Jul 12, 2019
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not sure about the coverage removal, but since nobody's looking at the report I'm fine removing it from the standard compile.

@d-a-v
Copy link
Collaborator Author

d-a-v commented Jul 13, 2019

coverage is disabled in the host emulation part only. CI host test still has it.

@d-a-v d-a-v merged commit cd6cf98 into esp8266:master Jul 13, 2019
@d-a-v d-a-v deleted the no9600 branch July 13, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-a-v @earlephilhower