Put InterruptLock (from interrupts.h) into namespace esp8266 #6225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow and future collisions with 3rd party Arduino libraries (currently Adafruit DHT has this issue)
dok-net
changed the title
|
@d-a-v @supersjimmie This is the fix for #6223 done in ESP8266 Arduino core. |
d-a-v
approved these changes
Jun 24, 2019
earlephilhower
approved these changes
Jun 24, 2019
There was a problem hiding this comment.
LGTM. Note, however, the semantics of this and adafruit/DHT-sensor-library#135 are very different and the DHT library must still be updated. On the 8266 we do a save/restore of the IPL. In the DHT library they are just blindly disabling all then re-enabling all IRQs. It may not be a problem in practice, but it is a different operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix now and future collisions with 3rd party Arduino libraries (currently Adafruit DHT has this issue).