Skip to content

Obey the BASIC_SSL request for TLS servers #6187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 8, 2019

Conversation

earlephilhower
Copy link
Collaborator

When in basic SSL mode, don't include ciphers for EC for the server by
replacinf the BearSSL "support everything" init call with our own
version which obeys the requested BASIC_SSL.

Saves ~47KB on TLS servers, about the same as basic SSL saves for
clients.

Also saves ~80bytes of heap due to some static local variables being removed.

When in basic SSL mode, don't include ciphers for EC for the server by
replacinf the BearSSL "support everything" init call with our own
version which obeys the requested BASIC_SSL.

Saves ~47KB on TLS servers, about the same as basic SSL saves for
clients.
Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@earlephilhower earlephilhower changed the title Obey the BASIC_SSL request for TLS servers WIP - Obey the BASIC_SSL request for TLS servers Jun 7, 2019
@earlephilhower earlephilhower changed the title WIP - Obey the BASIC_SSL request for TLS servers Obey the BASIC_SSL request for TLS servers Jun 7, 2019
@earlephilhower
Copy link
Collaborator Author

Just tested connecting to a server with and without, gives the expected ~46KB difference in program size and properly connects using allowed ciphers.

@earlephilhower earlephilhower merged commit fe01433 into esp8266:master Jun 8, 2019
@earlephilhower earlephilhower deleted the serverbasicfix branch June 8, 2019 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants