Skip to content

Fix spi slave timing (library SPISlave) #6022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 30, 2019
Merged

Fix spi slave timing (library SPISlave) #6022

merged 3 commits into from
Apr 30, 2019

Conversation

JiriBilek
Copy link
Contributor

I am fixing the PR #5489 that ended incorrectly. All facts described in the original PR hold.

@devyte devyte mentioned this pull request Apr 29, 2019
Closed
devyte
devyte approved these changes Apr 29, 2019
View reviewed changes
Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise this looks ok to me now. The reasoning seems sound as well, per timing screenshots in #5489.

@devyte devyte merged commit 13589b1 into esp8266:master Apr 30, 2019
@JiriBilek JiriBilek deleted the Fix_SPISlave_Timing branch May 1, 2019 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devyte devyte devyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JiriBilek @devyte