PlatformIO: generate core_version.h when using feature/stage #5917
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue: platformio/platform-espressif8266#101
Doc: https://docs.platformio.org/en/latest/platforms/espressif8266.html#using-arduino-framework-with-staging-version
Update platformio-build.py:
(however, I am not exactly sure if VerboseAction is a right way to call it, because dependency on git dir sometimes does not work properly)
Update makecorever.py:
if __name__ == "__main__"
, move generation into a function to clearly see git commandsgit --git-dir
with justgit -C
, since we already know that .git dir is there(unless I am missing some reason for git-dir setting. if it is required, it should probably be
--git-dir=.git --work-tree=. -C ...framework...
)