Skip to content

weak hook preinit() #2111 #2133 #2136 #5395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Dec 4, 2018
Merged

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Nov 30, 2018

Called in init_done() callback after global constructors initialized.
Or should it be called in user_init() (before global constructors) ?
#2111 #2133 #2136

@d-a-v d-a-v requested a review from igrr November 30, 2018 01:25
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a simple example to disable the WiFi stuff like in the issues? That's almost the only reason to have this.

Also need some kind of document about this weak call:
. No C++ allowed, no global objects, no interrupts or exceptions
. This is run in SYS context and can't take too long or yield/delay

Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the IP changes are intended, LGTM.

@d-a-v d-a-v changed the title weak hook early_setup() #2111 #2133 #2136 weak hook early_init() #2111 #2133 #2136 Nov 30, 2018
@d-a-v d-a-v changed the title weak hook early_init() #2111 #2133 #2136 weak hook preinit() #2111 #2133 #2136 Dec 3, 2018
@earlephilhower earlephilhower added this to the 2.5.0 milestone Dec 3, 2018
d-a-v and others added 4 commits December 3, 2018 23:18
camelCase for static method name
camelCase for static method name
Expand comment, fix static method name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants