-
Notifications
You must be signed in to change notification settings - Fork 13.3k
weak hook preinit() #2111 #2133 #2136 #5395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get a simple example to disable the WiFi stuff like in the issues? That's almost the only reason to have this.
Also need some kind of document about this weak call:
. No C++ allowed, no global objects, no interrupts or exceptions
. This is run in SYS context and can't take too long or yield/delay
…iFi sketches into WiFi examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the IP changes are intended, LGTM.
libraries/ESP8266WiFi/examples/EarlyDisableWiFi/EarlyDisableWiFi.ino
Outdated
Show resolved
Hide resolved
camelCase for static method name
camelCase for static method name
Expand comment, fix static method name
Expanded comment.
Expanded comment
Expanded comment
Called in
init_done()
callback after global constructors initialized.Or should it be called in
user_init()
(before global constructors) ?#2111 #2133 #2136