Make unique sections for ICACHE_* variables #5116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will also change flash and IRAM usage, same as the PROGMEM change did. A blank sketch reports 246008-243644 bytes of flash (2364 bytes) saved. I can't quite figure out how to find the end of iram, so that still needs to be checked. If there were repeated constant strings then it may actually have grown since gcc couldn't coalesce them (assuming it did before). |
devyte
approved these changes
Sep 10, 2018
Similar to PROGMEM changes, make the name of each ICACHE_* variable/fuction unique to avoid issues with section conflicts. Fixes esp8266#5115
earlephilhower
force-pushed
the
iram_names
branch
from
286c041 to
e9f587a
Compare
|
Closing this since #5117 fixes the bug found in the linker files. |
earlephilhower
added a commit
to earlephilhower/Arduino
that referenced
this pull request
Sep 19, 2018
Similar to PROGMEM changes, make the name of each ICACHE_* variable/fuction
unique to avoid issues with section conflicts.
Also rename the generated LD linker script to avoid issue with older copies
of the eagle.app.v6.common.ld which were generated by the build process
in a global directory before being moved to the {build.path}. The linker
would use the older, generated *.ld file instead of the generated one, which
would lead to runtime failures on some systems and cause the VTABLE location
to not correspond to the IDE menu selection.
Fixes esp8266#5115, and is an update to esp8266#5117 and esp8266#5116.
devyte
pushed a commit
that referenced
this pull request
Sep 21, 2018
* Move ICACHE_* to unique sections, local LD script
Similar to PROGMEM changes, make the name of each ICACHE_* variable/fuction
unique to avoid issues with section conflicts.
Also rename the generated LD linker script to avoid issue with older copies
of the eagle.app.v6.common.ld which were generated by the build process
in a global directory before being moved to the {build.path}. The linker
would use the older, generated *.ld file instead of the generated one, which
would lead to runtime failures on some systems and cause the VTABLE location
to not correspond to the IDE menu selection.
Fixes #5115, and is an update to #5117 and #5116.
* Update boards.txt.py and platform.io build
earlephilhower
added a commit
to earlephilhower/Arduino
that referenced
this pull request
Jul 24, 2019
Fixes esp8266#5116 Fixes esp8266#2743 The Arduino WiFiClient object allows sending the same packet to all connected clients of a WiFiServer. In their implementation it may make sense, but on the 8266 with things like SSL it doesn't. Update the docs to note that WiFiServer::write() is a no-op, and that the app should use the WiFiCliebnt::write() on all connected clients as appropriate.
d-a-v
pushed a commit
that referenced
this pull request
Jul 25, 2019
Fixes #5116 Fixes #2743 The Arduino WiFiClient object allows sending the same packet to all connected clients of a WiFiServer. In their implementation it may make sense, but on the 8266 with things like SSL it doesn't. Update the docs to note that WiFiServer::write() is a no-op, and that the app should use the WiFiCliebnt::write() on all connected clients as appropriate.
mikee47
added a commit
to mikee47/Sming
that referenced
this pull request
Aug 29, 2019
…flicts issue Thanks to esp8266/Arduino#5116
mikee47
added a commit
to mikee47/Sming
that referenced
this pull request
Sep 5, 2019
… section conflicts Thanks to esp8266/Arduino#5116 Commonly occurs when attempting to inline header methods, generally more of a problem with GCC 4.8.
mikee47
added a commit
to mikee47/Sming
that referenced
this pull request
Sep 5, 2019
… section conflicts Thanks to esp8266/Arduino#5116 Commonly occurs when attempting to inline header methods, generally more of a problem with GCC 4.8.
slaff
pushed a commit
to SmingHub/Sming
that referenced
this pull request
Sep 5, 2019
… section conflicts (#1829) Thanks to esp8266/Arduino#5116 Commonly occurs when attempting to inline header methods, generally more of a problem with GCC 4.8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to PROGMEM changes, make the name of each ICACHE_* variable/fuction
unique to avoid issues with section conflicts.
Fixes #5115