Skip to content

clean up SPI_FLASH_SEC_SIZE and/or FLASH_SECTOR_SIZE #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
holgerlembke opened this issue Aug 22, 2016 · 1 comment
Closed

clean up SPI_FLASH_SEC_SIZE and/or FLASH_SECTOR_SIZE #2421

holgerlembke opened this issue Aug 22, 2016 · 1 comment
Assignees
@devyte
Labels
level: easy type: code cleanup
Milestone
2.5.0

Comments

@holgerlembke
Copy link
Contributor

FLASH_SECTOR_SIZE is defined in cores/esp8266/flash_utils.h, while the SPI_FLASH_SEC_SIZE is defined in tools/sdk/include/spi_flash.h. They have both the same value and I assume they shall have the same meaning.

EEPROM uses SPI_FLASH_SEC_SIZE.

just to not confuse ppl...
@beyondszine beyondszine mentioned this issue Apr 10, 2017
Closed
@devyte
Copy link
Collaborator

devyte commented Oct 14, 2017

The referenced code is still present in latest git.
I think FLASH_SECTOR_SIZE should be #defined in terms of SPI_FLASH_SEC_SIZE, which comes from the Espressif SDK.

@devyte devyte self-assigned this Feb 8, 2018
@devyte devyte added this to the 2.5.0 milestone Feb 8, 2018
fabianoms added a commit to fabianoms/Arduino that referenced this issue Mar 13, 2018
@fabianoms
Code cleanup
7f41fbc 
FLASH_SECTOR_SIZE defined in terms of SPI_FLASH_SEC_SIZE (issue esp8266#2421).
@fabianoms fabianoms mentioned this issue Mar 13, 2018
Closed
@devyte devyte mentioned this issue Nov 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devyte devyte

Labels
level: easy type: code cleanup
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
2 participants
@holgerlembke @devyte