Skip to content

Add support for computed property names #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

rhendric
Copy link
Contributor

@rhendric rhendric commented Sep 4, 2019

No description provided.

@rhendric
Copy link
Contributor Author

rhendric commented Sep 4, 2019

After this and #98, the remaining PRs I intend to submit (adding support for rest parameters, default arguments, object/array destructuring in parameters, generators/yield, object literal methods, classes, and the super keyword) start to refactor existing AST constructors, instead of merely adding new ones. If you want to make a backwards-compatible-modulo-exhaustiveness-checks release (to be followed by a backwards-incompatible release shortly thereafter), the time to do that is after this and #98 are merged. If you don't think it matters, I have no issue until waiting until the rest of the work is submitted and merged too.

@erikd erikd merged commit 00775d2 into erikd:new-ast Sep 5, 2019
@rhendric rhendric deleted the submit/computed-property-names branch September 5, 2019 06:26
@rhendric rhendric mentioned this pull request Sep 29, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants