Skip to content

Add support for exotic parameter syntaxes #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2019
Merged

Add support for exotic parameter syntaxes #100

merged 2 commits into from
Sep 23, 2019

Conversation

rhendric
Copy link
Contributor

@rhendric rhendric commented Sep 5, 2019 •
edited
Loading

  • rest parameters
  • default arguments
  • object/array destructuring in parameters

@rhendric
Remove a stray ) from JSFunctionExpression
c822bf5 
... or, more precisely, from the ShowStripped representation of
JSFunctionExpression.
@rhendric
Add support for exotic parameter syntaxes
03f808a 
* rest parameters
* default arguments
* object/array destructuring in parameters
@rhendric rhendric changed the title Submit/exotic parameters Add support for exotic parameter syntaxes Sep 5, 2019
@erikd
Copy link
Owner

erikd commented Sep 5, 2019

Looks good, but I am going to leave it a day or two to see if anyone else has any comments.

@erikd erikd merged commit b2f4cfa into erikd:new-ast Sep 23, 2019
@rhendric rhendric deleted the submit/exotic-parameters branch September 23, 2019 18:27
@rhendric rhendric mentioned this pull request Sep 29, 2019
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikd erikd erikd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhendric @erikd