Skip to content

Drop "-upstream" suffix from docker image name #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2020
Merged

Drop "-upstream" suffix from docker image name #530

merged 1 commit into from
Jun 24, 2020

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jun 24, 2020

No description provided.

@sbc100
Copy link
Collaborator Author

sbc100 commented Jun 24, 2020

@trzecieu

@sbc100 sbc100 force-pushed the drop_upstream_suffix branch from f1e9230 to ef5e24d Compare June 24, 2020 01:29
@sbc100
Copy link
Collaborator Author

sbc100 commented Jun 24, 2020

Also remove the fastcomp binaries which we currently ship in the upstream SDK for historical reasons (this will save a bunch of space).

trzecieu
trzecieu approved these changes Jun 24, 2020
View reviewed changes
Copy link
Collaborator

@trzecieu trzecieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that currently emsdk install X.Y.Z does the same operation like emsdk install X.Y.Z-upstream 👍 and both operation succeeded.

LGTM

@trzecieu trzecieu mentioned this pull request Jun 24, 2020
Open
@sbc100 sbc100 merged commit eff1d2e into master Jun 24, 2020
@sbc100 sbc100 deleted the drop_upstream_suffix branch June 24, 2020 23:55
trzecieu added a commit that referenced this pull request Jun 25, 2020
@trzecieu
Update after #530
79bce4a
trzecieu added a commit that referenced this pull request Jun 25, 2020
@trzecieu
Update after #530
28f045d
trzecieu added a commit that referenced this pull request Jun 25, 2020
@trzecieu
Update after #530
b0fabd4
trzecieu added a commit that referenced this pull request Jun 25, 2020
@trzecieu
Update after #530
ce59d6d
trzecieu added a commit that referenced this pull request Jun 25, 2020
@trzecieu
Update after #530
20a604f
trzecieu added a commit that referenced this pull request Jun 25, 2020
@trzecieu
Update after #530
d144cc8
trzecieu added a commit that referenced this pull request Jul 4, 2020
@trzecieu
Update after #530
4774741
kleisauke pushed a commit to kleisauke/emsdk that referenced this pull request Jul 25, 2020
@trzecieu @kleisauke
Update after emscripten-core#530
64377de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

@trzecieu trzecieu trzecieu approved these changes

Assignees

@kripken kripken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbc100 @kripken @trzecieu