Skip to content

☝️ fix #53 #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

☝️ fix #53 #98

wants to merge 2 commits into from

Conversation

joeskeen
Copy link
Contributor

All generic parameters should appear on the same line in the docs

Before:
image

After:
image

All generic parameters should appear on the same line in the docs
@thbwd
Copy link
Member

thbwd commented Dec 16, 2022

Your changes seem to break some things like the package index (see screenshot) or the index page of the documentation:

https://deploy-preview-98--emojicode.netlify.app/docs/
https://deploy-preview-98--emojicode.netlify.app/docs/packages/

Screen Shot 2022-12-16 at 15 01 23

@joeskeen
Copy link
Contributor Author

Ah, good catch. I'll try to figure out how to prevent that from happening.

@joeskeen
Copy link
Contributor Author

@thbwd that should be fixed now. I made my style changes only be scoped to the .toc class so it shouldn't mess up anything else. I did some spot checking and things are looking better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants