Implement new diagnostics system #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is conflicting btw |
razzeee
reviewed
Nov 18, 2020
razzeee
reviewed
Nov 18, 2020
razzeee
reviewed
Nov 18, 2020
razzeee
reviewed
Nov 19, 2020
razzeee
reviewed
Nov 19, 2020
razzeee
reviewed
Nov 19, 2020
razzeee
reviewed
Nov 19, 2020
razzeee
reviewed
Nov 19, 2020
razzeee
reviewed
Nov 19, 2020
razzeee
reviewed
Nov 19, 2020
razzeee
reviewed
Nov 19, 2020
razzeee
reviewed
Nov 19, 2020
razzeee
reviewed
Nov 19, 2020
jmbockhorst
force-pushed
the
elm-diagnostics
branch
from
6d19995 to
7b25b45
Compare
* Add interruptable diagnostic provider * Enable type inference compiler diagnostics * Remove elm-analyse
jmbockhorst
force-pushed
the
elm-diagnostics
branch
from
7b25b45 to
4742a70
Compare
|
LGTM, let's fix the tests and get this merged. |
jmbockhorst
force-pushed
the
elm-diagnostics
branch
from
2c269c7 to
9e6a5da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the new diagnostics system with support for cancellation. Early testing is showing a dramatic increase in responsiveness of completions, diagnostics, etc on large workspaces. I enabled type inference diagnostics for now. While these are not ready for general use, they do work on some workspaces (Rare parsing bugs or type inference bugs can cause issues). We can remove these before the next release if they aren't stable enough or enabled them under a "experimental" setting. I will be testing this at work over the next few days to hopefully iron out any issues. Closes #351.
Here is a summary of the changes:
@nextversion of language server protocol to support file-based cancellation tokensClient PR: elm-tooling/elm-language-client-vscode#135