Improve the performance of changing the composer mode. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: this will only be noticeable once a new version of the RTE library is used and the crash when calling `renderComposerMode` is fixed. Also, improved the UI for full screen mode.
jmartinesp
pushed a commit
that referenced
this pull request
Feb 10, 2025
# This is the 1st commit message: feature(room preview): Add option to forget room, improve the room preview screen for banned rooms. Some internal refactoring was done too: - Remove RoomInfo.isPublic to only use JoinRule. - Also take into account restricted access rooms for previews. # The commit message #2 will be skipped: # feat(room preview) : handle new cases (restricted, banned) # The commit message #3 will be skipped: # feat(room preview) : remove RoomInfo.isPublic to only use JoinRule # The commit message #4 will be skipped: # feat(room preview) : continue managing all the states
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this will only be noticeable once a new version of the RTE library is used and the crash when calling
renderComposerModeis fixed.Also, improved the UI for full screen mode.
Its Element Android counterpart is element-hq/element-android#7691.