Skip to content

Update rich text editor library to support pasting of images #8517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

langleyd
Copy link
Member

@langleyd langleyd commented Jun 9, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

matrix-org/matrix-rich-text-editor#700 fixes an issue of non-text based paste actions being swallowed by the rte EditText.

Motivation and context

Fixes #8270

Screenshots / GIFs

Tests

  • Tests were added in the rte repo for pasting of text, html and images.
  • Manual tests were done that pasting of text, html and images work on on element android.

Tested devices

  • Physical
  • [ x Emulator
  • OS version(s):

Checklist

@langleyd langleyd requested a review from jonnyandrew June 9, 2023 08:50
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@langleyd langleyd merged commit 7d084f1 into develop Jun 9, 2023
@langleyd langleyd deleted the dla/feature/rte_paste_images branch June 9, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rich text editor] Cannot paste images when text formatting is enabled
3 participants